Getting values from http request in nodejs

2018-05-16 06:09 Jacob imported from Stackoverflow

var latLon = "40.8,-77.8"; //Lat/lon
var cityCode = ""; //City code
var cityName = "";
var latLongCityCodeURL = ("http://dataservice.accuweather.com/locations/v1/cities/geoposition/search?apikey=" + weatherKey + "&q=" + latLon);

//Current Conditions Vars
var ccWeatherText = ""; //Text for weather at location
var ccTemp = 0; //Degrees Farenheit
var ccIcon = 0; //weather icon number https://developer.accuweather.com/weather-icons
var ccURL = "test"; //URL for get
//12 hour forecast Conditions Vars


//5 day forecast conditions Vars

//Get city code
http.get(latLongCityCodeURL, (resp) => {
    var that = this;
    resp.on("data", (chunk) => {
        var result = JSON.parse(chunk);
        var cityCode = result.Key;
        var cityName = result.EnglishName;
        console.log(cityCode + " " + cityName);
        that.cityName = cityName;
        that.cityCode = cityCode;
    });

}).on("error", (err) => {
    console.log("Error: " + err.message);
});


console.log(cityCode + " " + cityName);

So my issue is, I am making an http request using require('http'), what I want to do is parse the data and store it in my global variables so that I can use them for other requests. I have tried using var that=this and I have tried just assigning my global variables to the data. I am not sure how to do it, i just keep getting undefined. I know it has something to do with ASYNC and also something to do with the scope. Please help

6 answers

answered 2018-05-16 06:24 scetiner
Your code block runs in a synchronized way and console.log part hits just after http.get call. The thing is http.get is an async function and its callback part will be called future ticks of NodeJS when your response has arrived.

answered 2018-05-16 06:27 Arif Khan

You can use Promise to make http request, here is code that may help you

const httpGet = url => {
    return new Promise((resolve, reject) => {
        http.get(url, res => {
            let body = '';
            res.on('data', chunk => body += chunk);
            res.on('end', () => {
                try {
                    body = JSON.parse(body);
                } catch (err) {
                    reject(new Error(err));
                }
                resolve({
                    cityCode: body.Key,
                    cityName: body.EnglishName
                });
            });
        }).on('error', reject);
    });
};


httpGet(latLongCityCodeURL).then(data => {
    console.log(data.cityCode + " " + data.cityName);
}).catch(err => console.log('Got error ', err));

answered 2018-05-16 06:28 cricket_007
You must wait for the response, then send the other requests or log into. The scope isn't really the issue here, it's the order of operations that you're missing. You define a variable, then wait for a HTTP request, meanwhile you're immediately logging a value, then the request finishes (or times out or other error), and you can log again the value - at which point you see data.

In other words, to fix the issue, other requests must be made from within a function of resp.on("end", which says when you've finished getting all data chunks

And by "within", the code can still be in a separate method, outside those brackets, but you must call that particular function from within that response body.

You should pass such asynchronous returned data through parameter variables, not update some external, global state in most cases

answered 2018-05-16 06:30 Terry Lennox

You can save your result to a variable at various levels of scope.. just remember that most i/o calls in Node.js are asynchronous. Here's an example:

var latLon = "40.8,-77.8"; //Lat/lon
var cityCode = ""; //City code
var cityName = "";
var latLongCityCodeURL = ("http://dataservice.accuweather.com/locations/v1/cities/geoposition/search?apikey=" + weatherKey + "&q=" + latLon);

//Current Conditions Vars
var ccWeatherText = ""; //Text for weather at location
var ccTemp = 0; //Degrees Farenheit
var ccIcon = 0; //weather icon number https://developer.accuweather.com/weather-icons
var ccURL = "test"; //URL for get


var savedResult = null;

//Get city code
http.get(latLongCityCodeURL, (resp) => {
    var jsonData = '';
    resp.on("data", (chunk) => {
        jsonData += chunk;
    });
    resp.on("end", () => {
        savedResult = JSON.parse(jsonData);
    });
}).on("error", (err) => {
    console.log("Error: " + err.message);
});


// Display saved result once available.
setTimeout(displaySavedResult, 2000);

function displaySavedResult() {
    if (!savedResult) {
        console.log('Last result is null!');
    } else {
        console.log('Last result: City Code: ' + savedResult.Key + " Name" + savedResult.EnglishName);
        console.log('Last result (all properties): ', JSON.stringify(savedResult, null, 2));
    }
}

answered 2018-05-16 06:35 anshuVersatile

var http = require('http');
var latLon = "40.8,-77.8"; //Lat/lon
var cityCode = ""; //City code
var cityName = "";
var latLongCityCodeURL = ("http://dataservice.accuweather.com/locations/v1/cities/geoposition/search?apikey=" + "fmKWSgaG5EAA0diCP2lSREEOYG6PC5q9" + "&q=" + latLon);
var that;
//Current Conditions Vars
var ccWeatherText = ""; //Text for weather at location
var ccTemp = 0; //Degrees Farenheit
var ccIcon = 0; //weather icon number https://developer.accuweather.com/weather-icons
var ccURL = "test"; //URL for get
//12 hour forecast Conditions Vars


//5 day forecast conditions Vars

//Get city code
getWeather = url => {
    return new Promise((resolve, reject) => {
        http.get(url, res => {
            let body = '';
            res.on('data', chunk => resolve(JSON.parse(chunk)));
        }).on('error', reject);
    });
};


getWeather(latLongCityCodeURL).then( weather => {
    console.log(weather.Key + " " + weather.EnglishName);
})

answered 2018-05-16 06:35 owaishanif786

var latLon = "40.8,-77.8"; 
var latLongCityCodeURL = ("http://dataservice.accuweather.com/locations/v1/cities/geoposition/search?apikey=" + weatherKey + "&q=" + latLon);

//Current Conditions Vars
var ccWeatherText = ""; //Text for weather at location
var ccTemp = 0; //Degrees Farenheit
var ccIcon = 0; //weather icon number https://developer.accuweather.com/weather-icons
var ccURL = "test"; //URL for get
//12 hour forecast Conditions Vars


//5 day forecast conditions Vars


//Get city code
function getCityCode(latLongCityCodeURL){
 return new Promise((resolve, reject) => {
  http.get(latLongCityCodeURL, (resp) => {
    resp.on("data", (chunk) => {
        var result = JSON.parse(chunk);
        var cityCode = result.Key;
        var cityName = result.EnglishName;
        resolve({cityCode, cityName});
    });

    }).on("error", (err) => {
       reject(err);
      console.log("Error: " + err.message);
   });

 })
}


getCityCode(latLongCityCodeURL)
.then((result) => { 
 console.log(result.cityCode, result.cityName) 
}).catch((err) => console.log(err))

Another way is to use async-await API interface which is supported in node 8.

async function getCityCode(latLongCityCodeURL){
 const result = await http.get(latLongCityCodeURL, (resp) => {
        resp.on("data", (chunk) => {
            var result = JSON.parse(chunk);
            var cityCode = result.Key;
            var cityName = result.EnglishName;
            return {cityCode, cityName};
        });

        }).on("error", (err) => {
           return err;
          console.log("Error: " + err.message);
       });

  return result;
}

getCityCode(latLongCityCodeURL)
.then((res) => { 

console.log(res.cityCode, res.cityName)

})

See also questions close to this topic

external .js variable coming back undifined?

I am trying to get an external .js variable into my index.html however the variable just comes back undefined. It works if the variable is in the HTML file but not when I call it from an outside .js file it just reads undefined ?

<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <link rel="stylesheet" href="assets/css/main.css" />

    <title>LoginSystem</title>

    <script src="../server.js"></script>

</head>    
<body>

    <div id="display"></div>

    <script>
        var t = setInterval(function() {
            // you can change `random` to any variable you want to be displayed

            document.getElementById("display").innerHTML = random;

        }, 500);
    </script>    
</body>

and the javascript file

var random = Math.random();

any help would be greatly appreciated thank you.

How to create a circular band using radial axis values in scatter polar chart using Plotly

I want to create a circular band inside a scatterpolar chart as follows:

For drawing band, I want to give two inputs: R_inner and R_outer values from radial axis so that I can modify band's thickness.

In the current image, I have plotted the band using marker with size. I have given the HTML,JS code as follows:

function getrandom(num , mul)
{
  var value = [ ]
    for(i=0;i<=num;i++)
   {
     rand = Math.random() * mul;
     value.push(rand);
   }
    return value;
};

function get_update_data()
{
    var data = [
        {
          type: "scatterpolargl",
          r: [50],
          theta: [0],
          mode: "markers",
          name: "Wall Radius",
          marker: {
            color: "green",
            size: 10,
            line: {
              color: "white"
            },
            opacity: 1
          },
          cliponaxis: false
        },
        {
          type: "scatterpolargl",
          r: [0],
          theta: [0],
          mode: "markers",
          name: "Band",
          marker: {
            symbol: "circle-open",
            color: "red",
            "sizemode": "diameter",
            size: 200,
            line: {
              width: 30
            },
            opacity: 0.3
          },
          cliponaxis: true
        },
      ];
    return data;
};

var layout =
{
    title: "",
    font: {
        size: 15
    },
    polar: {
        bgcolor: "rgb(255, 255, 255)",
        angularaxis: {
            tickwidth: 2,
            linewidth: 3,
            color: "rgb(0,153,204)",
            layer: "below traces"
        },
        radialaxis: {
            side: "counterclockwise",
            showline: false,
            tickwidth: 0,
            showgrid: true,
            color: "rgb(0,153,204)",
            ticks: "",
            showticklabels: true,
        }
    },
    paper_bgcolor: "rgb(255,255,255)",
    autosize: false,
    width: 400,
    height: 400,
    margin: {
        l: 10,
        r: 10,
        b: 50,
        t: 50,
        pad: 4
    },
};

function get_update_layout()
{
    return layout;
};

Plotly.newPlot('myDiv', get_update_data(), layout);

<head>
  <!-- Plotly.js -->
  <script src="https://cdn.plot.ly/plotly-latest.min.js"></script>
</head>

<body>
  
  <div id="myDiv"><!-- Plotly chart will be drawn inside this DIV --></div>
  <script>
    <!-- JAVASCRIPT CODE GOES HERE -->
  </script>
</body>

How to create responsive diagrams (like circle,lines etc) in my webpage?

I wanna design diagram like this (see the picture) for my web page picture. Here is the link of website. I want exactly this.

app.post and the express-fileupload dependency is producing no response

I have a simple html uploading form

<h1>Upload File Here</h1>

<form methods="post" enctype="multipart/form-data" action="/">
  <input type="file" name="filename" /> <input type="submit" value="upload" />
</form>

I want uploaded files to hit a "/upload" folder. I am using the following express code to do this.

const express = require("express");
const app = express();
upload = require("express-fileupload");

app.listen(80);

app.use(upload());

console.log("Server Started");
app.get("/", (req, res) => {
  res.sendFile(__dirname + "/index.html");
});
app.post("/", (req, res) => {
  if (req.files) {
    var file = req.files.filename,
      filename = file.name;
    file.mv("/upload/" + filename, err => {
      if (err) {
        console.log(err);
        res.send("error occured");
      } else {
        res.send("done!");
      }
    });
  }
});

When I start the server and go to localhost in Chrome, I see the upload form. If I try to upload something, the url box changes to reflect the file I tried to upload, but the file does not appear in the '/upload' folder. Any ideas on what obvious mistake I'm making??

Thanks!

Discord.io Running to shutdown audio data stream closes bot
When I call the command "!endSong" it shuts down the bot, and the code that I'm executing this with is:
```
    case 'endSong':
        stream.stop();
        break;
```
I don't want the bot to shutdown so please help me with how I should be executing this command and/or how to prevent it from shutting down.

express-typescript-react: Send a json response after sending the view from the same request

Following is my code for a simple express-server written in typescript.

import express from 'express';
import bodyParser from 'body-parser';
import path from 'path';
import fs from 'fs';
import { DISTDIR } from './shared/constants';
import LoginController from './controllers/login';
// import * as test from '../../helpers/util';

function name() {
  return {
    name: 'Amaan'
  };
}
class App {
  public express: express.Application;

  constructor() {
    this.express = express();
    this.middleware();
    this.routes();
  }
  private middleware(): void {
    this.express.use(function(req, res, next) {
      res.header('Access-Control-Allow-Origin', '*');
      res.header('Access-Control-Allow-Headers', '*');
      next();
    });
    this.express.use(bodyParser.json());
    this.express.use(bodyParser.urlencoded({ extended: false }));
  }
  private routes(): void {
    this.express.get('/', function(req, res) {
      res.sendFile(path.join(projectDir, 'dist', 'index.html'));
    });
  }
}
export default new App().express;

As you can see here, I am sending back the index.html which contains my React code.

this.express.get('/', function(req, res) {
  res.sendFile(path.join(projectDir, 'dist', 'index.html'));
});

Now I am facing a problem where I need to send a response from any API in that request as well. Something like this:

function name() {
  return {
    name: 'Amaan'
  };
}

private routes(): void {
  this.express.get('/', function(_, res) {
  res.setHeader('Content-type', 'text/html');
  fs.readFile(path.resolve(DISTDIR, 'index.html'), null, (err, data) => {
    if (err) {
      res.writeHead(404);
      res.write('Not found');
    } else {
      res.write(data);
    }
    res.setHeader('Content-type', 'text/json');
    res.send(name());
    res.end();
  });
});

This is giving me a 'Can\'t set headers after they are sent.' error.

Please tell me, how I can send a json response along with the view.

Related questions

Getting values from http request in nodejs

6 answers

See also questions close to this topic