Program skipping 'if' Statement and defaults to 'else'

2018-10-11 18:51 Savannah Stidham imported from Stackoverflow

I'm doing an assignment for my programming class, but something is wrong with my code (again) and I've spent the past hour and a half trying to debug it. The code is a sort of gambling game, where the user enters an amount to bet, and chooses either high, low, or sevens. high is when the die roll an 8 or higher, low is when the die roll a 6 or lower, and seven is when the die roll a total of 7. If the die rolls seven, the bet is multiplied by 4 and awarded to the user. Otherwise, when the user "loses", they lose the amount that they bet. I can't seem to figure out exactly what is wrong.

To begin with, the winnings are not correct. They are showing up in the console as "You won 128 dollars!" and then when the code repeats,the current pool always becomes 132, even when the user lost and money should have been subtracted. Also, the program skips the "if" statements in the determineWinnings method - it defaults to the else even when the user should have won. This is due in 20 minutes and I can't figure out how to fix it! Any help is sincerely appreciated!

package example;
import java.util.Scanner;

public class test
{

public static void main(String[] args)
{

    Scanner inScanner = new Scanner(System.in);
    int currentPool = 100; 
    int bet = ' ';
    char highLow = ' ';
    int roll = ' ';
    int winnings = ' ';

    System.out.println("You have " + currentPool + " dollars.");
    getBet(inScanner, currentPool);
    getHighLow(inScanner);
    determineWinnings(highLow, bet, roll);
    currentPool = currentPool + winnings;
    System.out.println("");

    while (bet != 0)
    {
        System.out.println("You have " + currentPool + " dollars.");
        getBet(inScanner, currentPool);
        getHighLow(inScanner);
        determineWinnings(highLow, bet, roll);
        currentPool = currentPool + winnings;
        System.out.println("");
    }


}



private static int getBet(Scanner inScanner, int currentPool)
{
    System.out.print("Enter an amount to bet (0 to quit): ");
    String strBet = inScanner.nextLine();
    int bet = Integer.parseInt(strBet);


    while (bet < 0 || bet > currentPool)
    {
        System.out.print("Your bet MUST be between 0 and " + currentPool + " dollars.");
        System.out.println("You have " + currentPool + " dollars.");
        System.out.print("Enter an amount to bet (0 to quit): ");
        strBet = (inScanner.nextLine());
        bet = Integer.parseInt(strBet);
    }

    if (bet == 0)
    {
        System.out.println("You have " + currentPool + " dollars.");
        System.out.println("Goodbye!");
        return bet;
    }
    else
    {
        return bet;
    }
}


private static char getHighLow(Scanner inScanner)
{
    System.out.print("High, Low, or Sevens (H/L/S): ");
    String hls = inScanner.nextLine();
    char highLow = ' ';

    if (hls.equals("H") || hls.equals("h"))
    {
        highLow = 'H';
    }
    else if (hls.equals("L") || hls.equals("l"))
    {
        highLow = 'L';
    }
    else if (hls.equals("S") || hls.equals("s"))
    {
        highLow = 'S';
    }
    else
    {
        System.out.print("ERROR: invalid character entered. Please try again.");

        while (!hls.equals("H") || !hls.equals("h") || !hls.equals("L") || !hls.equals("l") || !hls.equals("S") || !hls.equals("s"))
        {
            System.out.println("High, Low, or Sevens (H/L/S): ");
            hls = inScanner.nextLine();
        }
    }
    return highLow;
}   


private static int getRoll()
{
    int roll = (int)Math.floor(Math.random() * 6 + 1);
    return roll;
}


private static int determineWinnings(char highLow, int bet, int roll)
{
    int rollOne = getRoll();
    int rollTwo = getRoll();
    int total = rollOne + rollTwo;
    int winnings = bet + 0;
    System.out.println("Die 1 rolls: " + rollOne);
    System.out.println("Die 2 rolls: " + rollTwo);
    System.out.println("Total of two dice is: " + total);

    if (highLow == 'H')
    {
        if (total >= 8)
        {
            System.out.println("You won " + winnings + " dollars!");

        }
        else
        {
            System.out.println("You lost!");
            winnings = 0 - bet;

        }
    }
    else if (highLow == 'L')
    {
        if (total <= 6)
        {
            System.out.println("You won " + winnings + " dollars!");

        }
        else 
        {
            System.out.println("You lost!");
            winnings = (0 - bet);

        }
    }
    else
    {
        if (total == 7)
        {
            winnings = bet * 4;
            System.out.println("You won " + winnings + " dollars!");

        }
        else 
        {
            System.out.println("You lost!");
            winnings = 0 - bet;

        }
    }
    return winnings;
}

}

2 answers

answered 2018-10-11 19:20 Dawood ibn Kareem
The part you haven't understood is that every method - in fact, every call to every method - has its own collection of local variables. That means that
- the winnings variable declared in main is NOT the same variable as the winnings variable declared in determineWinnings;
- the bet variable declared in main is NOT the same variable as the bet variable declared in getBet.
What you need to do is to make sure that the value returned by each called method is assigned to the variable that you want to store it in, in the caller method. So in main, when you call getBet, you actually want to write
```
bet = getBet(inScanner, currentPool);
```
so that the value returned from getBet gets assigned to the bet variable from main. Similarly, when you call determineWinnings, you need to write
```
winnings = determineWinnings(highLow, bet, roll);
```
so that the value returned from determineWinnings gets assigned to the winnings variable from main.

If you don't do that, then all the variables in main just keep their original values, which are 100 for currentPool and 32 for winnings (because ' ' is just another way to write 32). That's why your final value turns out to be 132.
answered 2018-10-11 19:32 sachin patel
To avoid skipping if in execution use

bet = getBet(inScanner, currentPool); highLow = getHighLow(inScanner); winnings = determineWinnings(highLow, bet, roll);

instead of directly calling

getBet(inScanner, currentPool); getHighLow(inScanner); determineWinnings(highLow, bet, roll);

Reson for skipping if statement and wrong answer:

getBet(inScanner, currentPool) method is returning the value which is not assigned to

int bet = ' '; java tries to convert ' ' to an integer which is 32. so bet is every time assigned 32 value when you call getBet(inScanner, currentPool) even if the entered value is different(which will give wrong answer).

In the case of getHighLow(inScanner) method is returning char value but since it is not assigned to highLow, highLow will always have value ' '.

since highLow has not assigned the actual value(H/L/S), if statement will be skipped as ' '!=(H/L/S) and always statements in else are executed.

See also questions close to this topic

Updating Kafka Offset Immediately
I am developing a Spring Boot app that reacts to messages pushed onto a Kafka queue.

The version is Spring Boot 2.0.5, Finchley.SR1.

The Kafka version is kafka_2.12-1.1.0

The issue I am facing is that sometimes when I restart the application it replays old messages. This doesn't always happen - the only pattern I have spotted is that it seems to be after a few days of inactivity (say on Monday morning, just after the weekend).

I stop and start the app multiple times during the day as part of the development and don't see the same issue, only sporadically. It isn't linked to errors in the application either, as all the processing is clean.

I have configured my Kafka listener to use MANUAL_IMMEDIATE acknowledgement, and call ack.acknowledge() at the end of the listener method.

My Spring property file looks as follows:
```
spring:
  kafka:
    bootstrap-servers: kafka:9092
    listener:
      ack-mode: MANUAL_IMMEDIATE
    consumer:
      enable-auto-commit: false
      auto-offset-reset: earliest
      group-id: user-mgmt-app
```
My Listener class is defined as follows:
```
@org.springframework.kafka.annotation.KafkaListener(topics = "aggregate-event-topic")
public void receive(ConsumerRecord<?, ?> cr, Acknowledgment ack) {

   ...
   ack.acknowledge();

}
```
I have one instance of the app running, so it's the leader in the consumer group each time.

I have used the Kafka tools to look at the offset for the consumer group, and one thing I've noticed is that when I breakpoint the app at the acknowledge step it's not updating the CURRENT-OFFSET, it only seems to update it once all messages have been processed.

./kafka-consumer-groups.sh --bootstrap-server kafka:9092 --group user-mgmt-app --describe

My understanding from other posts was that MANUAL_IMMEDIATE would update the Kafka server straight away after calling acknowedge(), rather than at the end of the batch.

Is my understanding incorrect? If so is there anyway to get the functionality I want (such as setting the batch size to 1 on each read from the partition, which I'm guessing may have performance implications). If so, how do I do this (any help gratefully accepted!)

TIA

Java Spring with mustache keeps looking for files on server

I've been trying to develop a quick website using Java Spring with Mustache for templating but I have an issue when it comes to getting local files (css stylesheets or images). I'm running the website on intelliJ on http://localhost:8000 and for some reason it looks for every files on http://localhost:8000/Path/to/the/file and returns a 404 error on the inspector (no error in the console log)

Here are my file-tree and the code I'm using. The templates .mustache are in the templates directory.

<nav class="level">
    <div class="level-left">
        <div class="level-item">
            <img src="/img/flags/gb.svg"/>
        </div>
        <div class="level-item">
            <img src="/img/flags/fr.svg"/>
        </div>
        <div class="level-item">
            <img src="/img/flags/es.jpg"/>
        </div>
        <div class="level-item">
            <img src="/img/flags/ch.svg"/>
        </div>
        <div class="level-item">
            <img src="/img/flags/de.svg"/>
        </div>
    </div>
</nav>

I saw some posts telling to add a resource handler like this :

registry.addResourceHandler("/css/**").addResourceLocations("/resources/static/css");
registry.addResourceHandler("/img/**").addResourceLocations("/resources/static/img");
registry.addResourceHandler("/resources/**").addResourceLocations("/resources/static/");

But no luck so far. Any help would be appreciated.

How can I expose my Rest services in multiple swagger pages.

I am using Spring boot to create some Rest services. How can I expose my Rest services in multiple swagger pages. For example All delete methods be in a separated page!
SQL join 2 tables with condition taking some default NULL values due to condition
I am taking some data from tables using join,
```
    SELECT da.aName AS aName FROM dbo.bTable 
INNER JOIN aTable da ON dbo.bTable.nameType = da.ID"
```
This select works. But if nameType is some new number which is not in da.ID, then this row is not shown at all. what I want is to join these to tables, but if aTable does not contain such number at all then some default values must be taken.

Here is an example. aTable is table of names
```
id=1 aName = bmw
id=2 aName= mersedes
id=3 aName= audi
```
bTable has list of cars and I must get them all
```
1    nameType =1
2    nameType =2
3    nameType =3
4    nameType =5
```
So I must show all 4 cars. And with my code I will show only 3, because nameType of number 4 car is 5. And there is no such ID in aTable. The result will be

1 car is bmw

2 car is mersedes

3 car is audi

What I want to do is in such case aTable to give some NULL values or something so the result must be like

1 car is bmw

2 car is mersedes

3 car is audi

4 car is NULL

two list find values

should look something like this:

if items in both lists (equal/ larger/smaller):
   do something
else:
   if items in both lists (equal/ larger/smaller):
       do something
   else:
       do something

how to get an if statement to restart from a certain line of code in java?

I am a student who is relearning java and I am looking for a way to have player 2 rolls again (since if a player rolls a double they get to roll again), however, if I use continue then it will jump back to the top of the do while statement. Any ideas would be appreciated! here is the code:

/A2.java
/to simulate a double dice game between 2 players; the first one to reach a  
score of 75 wins

public class A2
{
public static void main (String[]args)
{
{
  //intitialize variables
  int playerOneScore = 0;
  int playerTwoScore = 0;
  int win = 75;
  do {
    //PLAYER 1
    int diceOne = (int)(Math.random()*6)+1;
    int diceTwo = (int)(Math.random()*6)+1;
    int sum = diceOne+diceTwo;
    playerOneScore=playerOneScore+sum;
    if (diceOne==diceTwo)
    {
      System.out.println ("player 1 rolled a "+diceOne+" and a "+diceTwo);
      System.out.println ("player 1 now has a score of : "+playerOneScore);
      //to break the loop immediatly if one player wins
      if (playerOneScore>win)
      {
        break;
      }
      System.out.println ("player 1 now gets to roll again");
      sum=0;
      continue;
    }
    else if (diceOne!=diceTwo)
    {
      System.out.println ("player 1 rolled a "+diceOne+" and a "+diceTwo);
      System.out.println ("player 1 now has a score of : "+playerOneScore);
      sum=0;
    }
    //to break the loop immediatly if one player wins
    if (playerOneScore>win)
    {
      break;
    }
    //PLAYER 2
    diceOne = (int)(Math.random()*6)+1;
    diceTwo = (int)(Math.random()*6)+1;
    sum = diceOne+diceTwo;
    playerTwoScore=playerTwoScore+sum;
    if (diceOne==diceTwo)
    {
      System.out.println ("player 2 rolled a "+diceOne+" and a "+diceTwo);
      System.out.println ("player 2 now has a score of : "+playerTwoScore);
      //to break the loop immediatly if one player wins
      if (playerOneScore>win)
      {
        break;
      }
      System.out.println ("player 2 now gets to roll again");
      sum=0;
 //**********************THIS IS WHERE MY PROBLEM IS***********************
      continue;
    }
    else if (diceOne!=diceTwo)
    {
      System.out.println ("player 2 rolled a "+diceOne+" and a "+diceTwo);
      System.out.println ("player 2 now has a score of : "+playerTwoScore);
      sum=0;
    }
    //to break the loop immediatly if one player wins
    if (playerOneScore>win)
    {
      break;
    }
  }while (playerOneScore<=win && playerTwoScore<=win );
  if (playerOneScore>win)
  {
    System.out.println ("player 1 wins with a score of : "+playerOneScore);
  }
  else if (playerTwoScore>win)
  {
    System.out.println ("player 2 wins with a score of : "+playerTwoScore);
   }
  }
 }
}

sorry for the terrible formatting

EDIT: It works now, thank you Scary Wombat for helping me! below is the working code in case someone else also has a similar question:

//A2.java
//to simulate a double dice game between 2 players; the first one to reach a 
score of 75 wins

public class A2
{
  public static void main (String[]args)
{
 {
  //intitialize variables
  int playerOneScore = 0;
  int playerTwoScore = 0;
  int win = 75;
  do {
    //PLAYER 1
    int diceOne = (int)(Math.random()*6)+1;
    int diceTwo = (int)(Math.random()*6)+1;
    int sum = diceOne+diceTwo;
    playerOneScore=playerOneScore+sum;
    if (diceOne==diceTwo)
    {
      System.out.println ("player 1 rolled a "+diceOne+" and a "+diceTwo);
      System.out.println ("player 1 now has a score of : "+playerOneScore);
      //to break the loop immediatly if one player wins
      if (playerOneScore>win)
      {
        break;
      }
      System.out.println ("player 1 now gets to roll again");
      sum=0;
      continue;
    }
    else if (diceOne!=diceTwo)
    {
      System.out.println ("player 1 rolled a "+diceOne+" and a "+diceTwo);
      System.out.println ("player 1 now has a score of : "+playerOneScore);
      sum=0;
    }
    //to break the loop immediatly if one player wins
    if (playerOneScore>win)
    {
      break;
    }
    //PLAYER 2
    boolean t=true;
    while (t){
      diceOne = (int)(Math.random()*6)+1;
      diceTwo = (int)(Math.random()*6)+1;
      sum = diceOne+diceTwo;
      playerTwoScore=playerTwoScore+sum;
      if (diceOne==diceTwo)
      {
        System.out.println ("player 2 rolled a "+diceOne+" and a "+diceTwo);
        System.out.println ("player 2 now has a score of : 
"+playerTwoScore);
        //to break the loop immediatly if one player wins
        if (playerOneScore>win)
        {
          break;
        }
        System.out.println ("player 2 now gets to roll again");
        sum=0;
        //NEED TO FIX, KEEPS JUMPING TO BEGINING AGAIN
        continue;
      }
      else if (diceOne!=diceTwo)
      {
        System.out.println ("player 2 rolled a "+diceOne+" and a "+diceTwo);
        System.out.println ("player 2 now has a score of : 
"+playerTwoScore);
        sum=0;
      }
      //to break the loop immediatly if one player wins
      if (playerOneScore>win)
      {
        break;
      }
      break;
    }
  }while (playerOneScore<=win && playerTwoScore<=win );
  if (playerOneScore>win)
  {
    System.out.println ("player 1 wins with a score of : "+playerOneScore);
  }
  else if (playerTwoScore>win)
  {
    System.out.println ("player 2 wins with a score of : "+playerTwoScore);
      }
    }
  }
}

Related questions

Program skipping 'if' Statement and defaults to 'else'

2 answers

See also questions close to this topic