Minecraft Server not letting people in even after port forwaring

Good evening, i have tried setting up a minecraft server for few months now, just for me and my friends to play on . I downloaded the server file and set it up properly and allowed inbound and outbound rules through my windows firewall to the specific port (25565) but its not letting my friends in, and online port checker tools says that my port is closed. Any help would be greatly appreciated, thank you.