Is it wrong to add action to button in tableViewCell with tag?

2022-01-19 17:01 Alireza12t imported from Stackoverflow

I have a UItableViewCell with a button inside it, I set the tag of the button and add the action of the button in my ViewController using the tag.

func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(withIdentifier: "BillHistoryTableViewCell", for: indexPath) as! BillHistoryTableViewCell
        let cellData = billHistories[indexPath.row]
        cell.setup(with: cellData)
        cell.retryButton.tag = indexPath.row
        return cell
}

@IBAction func billHistoryRetryButtonDidTap(_ sender: UIButton) {
        let index = sender.tag
        if let id = billHistories[index].transactionInfo?.billUniqueID {
            hidePayIdGeneralTextField()
            billIdTextField.text = id.toNormalNumber()
            inquiryGeneralBillRequest()
        }
}

I want to know is it wrong for any reason? someone told me it is not good because it uses lots of memory to use tags.

1 answer

answered 2022-01-19 21:41 Maor Atlas

Will it work? yes, but as mentioned above, this is not the best approach, I'd avoid using tags unless this is just for some POC. There are better approaches to handle it. The first I'd suggest is using delegation to inform back to the controller, here's an example:

class BillHistoryTableViewController {
    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(withIdentifier: "BillHistoryTableViewCell", for: indexPath) as! BillHistoryTableViewCell
        let cellData = billHistories[indexPath.row]
        cell.setup(with: cellData)
        cell.index = indexPath.row
        
        cell.delegate = self
        return cell
    }
}

extension BillHistoryTableViewController: BillHistoryTableViewCellDelegate {
    func didTapButton(index: Int) {
        print("tapped cell with index:\(index)")

        if let id = billHistories[index].transactionInfo?.billUniqueID {
            hidePayIdGeneralTextField()
            billIdTextField.text = id.toNormalNumber()
            inquiryGeneralBillRequest()
        }
    }
}

protocol BillHistoryTableViewCellDelegate: AnyObject {
    func didTapButton(index: Int)
}

class BillHistoryTableViewCell: UITableViewCell {
    weak var delegate: BillHistoryTableViewCellDelegate?
    var cellData: CellData?
    var index: Int?
    
    func setup(with cellData: CellData) {
        self.cellData = cellData
    }
    
    @IBAction func buttonPressed(_ sender: UIButton) {
        guard let index = index else {
            return
        }
        
        delegate?.didTapButton(index: index)
    }
}

Another approach that I prefer lately is using Combine's PassThroughSubject, it requires less wiring and delegate definitions.

import Combine

class BillHistoryTableViewController {
    var cancellable: AnyCancellable?
    
    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(withIdentifier: "BillHistoryTableViewCell", for: indexPath) as! BillHistoryTableViewCell
        let cellData = billHistories[indexPath.row]
        cell.setup(with: cellData)
        cell.index = indexPath.row
        
        cancellable = cell.tappedButtonSubject.sink { [weak self] index in
            guard let self = self else { return }
            print("tapped cell with index:\(index)")

            if let id = self.billHistories[index].transactionInfo?.billUniqueID {
                self.hidePayIdGeneralTextField()
                self.billIdTextField.text = id.toNormalNumber()
                self.inquiryGeneralBillRequest()
            }
        }
        
        return cell
    }
}

class BillHistoryTableViewCell: UITableViewCell {
    var tappedButtonSubject = PassthroughSubject<Int, Never>()
    
    var cellData: CellData?
    var index: Int?
    
    func setup(with cellData: CellData) {
        self.cellData = cellData
    }
    
    @IBAction func buttonPressed(_ sender: UIButton) {
        guard let index = index else {
            return
        }
        
        tappedButtonSubject.send(index)
    }
}

You can make it even shorter by injecting the index with the cellData, e.g:

func setup(with cellData: CellData, index: Int) {
    self.cellData = cellData
    self.index = index
}

but from what I see in your example, you don't even need the index, you just need the CellData, so if we'll take the Combine examples these are the main small changes you'll have to make:

var tappedButtonSubject = PassthroughSubject<CellData, Never>()

tappedButtonSubject.send(cellData)

and observing it by:

cancellable = cell.tappedButtonSubject.sink { [weak self] cellData in
    if let id = cellData.transactionInfo?.billUniqueID {
        //
    }
}

See also questions close to this topic

Command failed: xcrun instruments -s

I want to run my react native app on a real ios device with this line :

npx react-native run-ios --udid SOME-UDID

but i got this error :

xcrun: error: sh -c '/Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -find instruments 2> /dev/null' failed with exit code 17664: (null) (errno=No such file or directory)
xcrun: error: unable to find utility "instruments", not a developer tool or in PATH
error Command failed: xcrun instruments -s
xcrun: error: sh -c '/Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -find instruments 2> /dev/null' failed with exit code 17664: (null) (errno=No such file or directory)
xcrun: error: unable to find utility "instruments", not a developer tool or in PATH

everything is ok on simulator

I'm using XCODE 13

IOS Launcher in android studio

I'm trying to change the whole Android OS installed app icons into IOS icons, please help me with the proper code or library for android kotlin

Debugging undefined is not an object (evaluating 'Object.keys(routeConfigs)')

I'm using Expo and React Native to create a simple iOS app. I am currently getting this error and have no idea how to fix it. I've tried various other solutions on Stack Overflow to no avail.

My code is:

import 'react-native-gesture-handler';
import React from 'react';
import { createStackNavigator } from 'react-navigation-stack';
import { NavigationContainer } from '@react-navigation/native';
import HomeScreen from './src/screens/HomeScreen';

const Stack = createStackNavigator();

export default function App() {
  return (
    <NavigationContainer>
    <Stack.Navigator>
      <Stack.Screen name="Home" component={HomeScreen} />
    </Stack.Navigator>
    </NavigationContainer>
  );
}

Here is my HomeScreen.js

import React from 'react';
import { Text, View } from 'react-native';

export default function HomeScreen () {
  return (
    <View>
      <Text>Welcome Home!</Text>
    </View>
  )
}

My packages:

  "packages": {
    "": {
      "name": "safey",
      "version": "1.0.0",
      "dependencies": {
        "@react-native-community/masked-view": "^0.1.11",
        "@react-navigation/native": "^6.0.10",
        "@react-navigation/stack": "^6.0.10",
        "expo": "~45.0.0",
        "expo-splash-screen": "~0.15.1",
        "expo-status-bar": "~1.3.0",
        "react": "17.0.2",
        "react-dom": "17.0.2",
        "react-native": "0.68.1",
        "react-native-gesture-handler": "^2.4.2",
        "react-native-reanimated": "^2.8.0",
        "react-native-safe-area-context": "^4.2.5",
        "react-native-screens": "^3.13.1",
        "react-native-web": "0.17.7",
        "react-navigation": "^4.4.4",
        "react-navigation-stack": "^2.10.4"
      },

SwiftUI, apply drawGesture only when over Image

I'm try to apply the gesture only when the user is over the Image display not when tapped outside the image.

Any suggestion how I can do? this following code draw also when user tap outside the image.

struct ContentView: View {
    @StateObject var am = AppManager()
    @State var switchToTakePicture = false
    @State var paths: [PathContainer] = []
    @State var currentDraggingId = UUID()
    @State var spikoPic = #imageLiteral(resourceName: "spiko-16.jpeg")
    @State var centerOFimage = CGSize(width: 0, height: 0)
    var body: some View {
        
        GeometryReader { proxy in
            ZStack {
                Image(uiImage: spikoPic)
                    .resizable()
                    .scaledToFit()
                    .position(x: proxy.size.width/2, y: proxy.size.height/2)
                    .background(GeometryReader {
                        Color.clear.preference(key: ViewRectKey.self,
                                               value: [$0.frame(in: .global)])
                    })
                    .gesture(drawGesture) // not correct
                
                ForEach(paths) { container in
                    // draw and set the foreground color of the paths to red
                    container.path
                        .stroke(Color.red, lineWidth: 4)
                    
                    
                }
            }
            .onPreferenceChange(ViewRectKey.self) { rects in
                print(rects.first ?? .zero)
                
            }
        }
        
    }
    var drawGesture: some Gesture {
        
        DragGesture(minimumDistance: 0)
            .onChanged { value in
                
                // The point that the gesture started from
                let start = value.startLocation
                // The point that the gesture ended to
                let end = value.location
                // the properties of the rectangle to be drawn
                let rectangle: CGRect = .init(origin: end,
                                              size: .init(width: start.x - end.x,
                                                          height: start.y - end.y))
                // create a path for the rectangle
                let path: Path = .init { path in
                    
                    path.addRect(rectangle)
                }
                
                print("rettangolo = \(rectangle) orig \(rectangle.origin) - height \(rectangle.height) width = \(rectangle.width)")
                
                // remove the previous rectangle that was drawen in current
                // process of drawing
                paths.removeAll { $0.id == currentDraggingId }
                // append the new rectangle
                paths.append(.init(id: currentDraggingId, path: path))
            }
            .onEnded { _ in
                // renew the dragging id so the app know that the next
                // drag gesture is drawing a completely new rectangle,
                // and is not continuing the drawing of the last rectangle
                currentDraggingId = .init()
            }
    }
}

i want no box outside

How to navigate between NavigationLink while leave a part of main window stay the same in SwiftUI
I would like to navigate between different NavigationLinks in NavigationView while some part of the main window stay the same. For example, I want to make a music app and I want to let the play controller always on top, while I can display different navigation contents (songs page, artists page...) using the rest of the window.

Like what's showed in the picture below, I want to keep the red part always there while the blue part changes.

Navigation Example Picture

My code would be like below, but it won't work correctly. The AlwaysStayView() disappears when I click any NavigationLink on sidebar. So, how can I correct it or is there any solution (prefer in SwiftUI, but framework like UIKit would also be OK). I would appreciate it.
```
NavigationView {
            List {
                NavigationLink { DiscoverView() }
                    label: { Label("Discover", systemImage: "magnifyingglass") }
                NavigationLink { SongsView() }
                    label: { Label("Songs", systemImage: "music.note") }
                NavigationLink { ArtistsView() }
                    label: { Label("Artists", systemImage: "music.mic") }
                }
            }
            .listStyle(SidebarListStyle())

            VStack {
                AlwaysStayView()
                SongsView()
            }
}
```

NumberFormatter and unsigned with UInt64.max

I'm trying to create a string representing UInt64.max using NumberFormatter. Here's the code:

let formatter = NumberFormatter()
    
formatter.usesGroupingSeparator = true
formatter.numberStyle = .decimal
formatter.positiveFormat = "# ##0.#########"
formatter.maximumSignificantDigits = 20
formatter.usesSignificantDigits = false
formatter.maximumFractionDigits = 20
formatter.minimumFractionDigits = 0
formatter.alwaysShowsDecimalSeparator = false
// formatter.roundingMode = .halfUp
let text1 = formatter.string(for: NSNumber(value: Int64.max))
let text2 = formatter.string(for: NSNumber(value: UInt64.max))

print(text1)
print(text2)

which prints:

Optional("9,223,372,036,854,780,000")
Optional("-1")

but should print

Optional("9223372036854775807")
Optional("18,446,744,073,709,551,615")

It looks like NSNumber is rounding Int64 and isn't taking the UIn64. The obj-c version of NSNumberFormatter works fine.

Am I missing something or is there a problem with NumberFormatter?

ios 15.2 Objective-C Mutiple UITableViews on single screen crashing when scrolling
I have two UITableViews on my view with two buttons acting as tabs on top of the view. I hide and show one of the tableview based on user selection. When I come to the view everything seems fine with first tab selected and tableview loaded with data , when I move to second tab the data on the second UItableView is loaded and visble but when I try to scroll the app is crashing.

Crash is happening at tableView:heightForRowAtIndexPath:].
- (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath
When I print the table tag and indexPath in the above method it is still pointing to UITableView from first tab which is hidden.

But when I do a scroll action on first tab UITableView and then go the second tab I am able to scroll the UITableView.

Things were working fine on previous version on ios.

I appreciate any help.

SwiftUI Custom List Cell - disable horizontal padding/shrink in EditMode

I'm trying to create a custom List cell in SwiftUI, where the drag-icon in Edit Mode stays inside the cell.

By default, the cell gets horizontally shrinked do make space for the drag handle and delete button, as soon as the list enters Edit Mode.

Actually adding a listRowBackground could do the trick, but then I'm not able to add cornerRadius and padding anymore.

What happens right now:

Desired behaviour:

Does anyone know a trick or solution with introspect how to achieve that?

Example Code:

struct ListInList: View {

    @State var datas = ["Row 1", "Row 2", "Row 3"]

    var body: some View {
        NavigationView{
            List{
            
                ForEach(datas, id: \.self) { data in
                    HStack{
                        Text(data)
                            .frame(maxWidth: .infinity)
                            .padding()
                    }
                    .listRowSeparator(.hidden)
                    .listRowInsets(EdgeInsets())
                    .listRowBackground(Color.clear)
                    .ignoresSafeArea(edges: .horizontal)
                    .background(Color.gray.opacity(0.3))
                    .cornerRadius(10)
                    .deleteDisabled(true)
                    .padding(EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16))
                }
                .onMove(perform: move)
            }
            .listStyle(.plain)
            .toolbar{
                ToolbarItem(placement: .navigationBarTrailing){
                    EditButton()
                }
            }
        }
    }

    func move(from source: IndexSet, to destination: Int) {
        datas.move(fromOffsets: source, toOffset: destination)
    }
}

Pros/cons of implementing a particular set of delegate methods versus not implementing them and the effects of implementing one but not another?

In regards to UITableView & UICollectionView & their respective protocols, UITableViewDataSource & UITableViewDelegate + UICollectionViewDelegate & UICollectionViewDataSource -- are there any pros and cons to implementing one method, but not the other or a particular set of methods and not the rest of the methods or a unique combination of specific methods?

For example, if I am to implement heightForFooter but not viewForFooter - what happens or can happen? Does this negative impact performance or the scroll of the table view?

Is there a guide which shows that which if any methods are implemented, others should be combined and dually implemented alongside them?

Related questions

Is it wrong to add action to button in tableViewCell with tag?

1 answer

See also questions close to this topic